scikit-learn-extra
scikit-learn-extra copied to clipboard
RFC Process for giving commit rights
I think we should formalize a bit way commit rights are given for scikit-learn-extra
.
Currently following groups can modify code in this repo,
- @scikit-learn-contrib/scikit-learn-extra team (currently containing @glemaitre and myself)¹
- owners of the scikit-learn-contrib org (28 people in total)
I think this is not very sustainable and we should give commit rights to scikit-learn-extra
for contributors who have made significant contributions (in code or otherwise cf https://scikit-learn.org/stable/developers/contributing.html) and are interested/available in helping with the maintenance work.
(Also I guess the use of groups for managing permissions in this org could be improved in general).
I think this is not very sustainable and we should give commit rights to scikit-learn-extra for contributors who have made significant contributions (in code or otherwise cf https://scikit-learn.org/stable/developers/contributing.html) and are interested/available in helping with the maintenance work.
I am +1
yeah happy to expand the committer base if you have an idea who to add.
I would like to give commit rights for this repo to @chkoar who helped with code review and is already co-maintaining imbalanced-learn.
+1
+1
+1
no objection
It's done :)
+1
I would like to propose to add https://github.com/TimotheeMathieu to the scikit-learn-extra repo team, who has been doing useful contributions to this library for the last several months.
Fine for me! Thanks for suggesting
It's done.