scikit-learn-extra icon indicating copy to clipboard operation
scikit-learn-extra copied to clipboard

Refactor KMedoids

Open chkoar opened this issue 2 years ago • 0 comments

I tried to reduce the cyclomatic complexity in k medoids. During refactoring I realized that we are testing private methods. Why is that?

So, the tests in the private methods are failing. What should we do? Make the methods public, document and test them or just remove the tests by replace them with behavior testing on public methods?

I think that tests could be improved in general.

chkoar avatar Apr 09 '22 16:04 chkoar