metric-learn icon indicating copy to clipboard operation
metric-learn copied to clipboard

SCML: Add warm_start parameter

Open maxi-marufo opened this issue 2 years ago • 2 comments

Because SCML optimization procedure is based on stochastic subgradient descent, we can save the weights after fitting the model, and use them in a following fit call (with a different set of triplets). The decision to use the warm_start parameter instead of a new partial_fit method is because partial_fit in scikit-learn will only fit 1 epoch, whereas fit will fit for multiple epochs (until the loss converges or max_iter is reached), which is the case also for SCML.

maxi-marufo avatar Dec 08 '21 18:12 maxi-marufo

This change looks fine to me, though I'm not sure when this warm-start option is useful in practice. Sorry for the extreme delay in reviewing!

@grudloff want to take a look?

perimosocordiae avatar Jun 21 '22 00:06 perimosocordiae

LGTM!

grudloff avatar Jun 21 '22 19:06 grudloff