hdbscan icon indicating copy to clipboard operation
hdbscan copied to clipboard

Deprecated argument names in hdbscan_.py

Open joaquindas opened this issue 9 months ago • 3 comments

Sklearn deprecated force_all_finite param for check_array(). Docs here. There is a deprecation warning when fitting the model. check_array function is used twice in hdbscan_.py. Changed both to new param naming ensure_all_finite, functionality is identical.

joaquindas avatar Apr 01 '25 15:04 joaquindas

This change also increases the minimum required scikit-learn version from 0.2 to 1.6. Maybe it is worth testing which version is available at run-time to keep support for older scikit-learn versions?

JelmerBot avatar Apr 22 '25 15:04 JelmerBot

If dependencies were declared in pyproject.toml, it would be straightforward to specify scikit-learn version for given python versions. Is there interest in setting that up instead of requirements.txt?

joaquindas avatar Apr 28 '25 18:04 joaquindas