hdbscan icon indicating copy to clipboard operation
hdbscan copied to clipboard

Inconsistencies in Core Distance Computation

Open tarang-jain opened this issue 3 years ago • 1 comments

For computing the core distances, during training the (min_samples+1)-th neighbor is considered, but while building the PredictionData object, the (min_samples)-th neighbor is considered. The specific parts in the code that I am referring to are: https://github.com/scikit-learn-contrib/hdbscan/blob/379d523d4e6b059db30970c8f5a08f383d5f3a6f/hdbscan/hdbscan_.py#L245

and

https://github.com/scikit-learn-contrib/hdbscan/blob/379d523d4e6b059db30970c8f5a08f383d5f3a6f/hdbscan/prediction.py#L103

tarang-jain avatar Sep 01 '22 15:09 tarang-jain

Hey, I would be willing to work on this. Can this please be assigned to me?

traderjoesbrownielover avatar Sep 19 '22 00:09 traderjoesbrownielover