MAPIE icon indicating copy to clipboard operation
MAPIE copied to clipboard

Missing random state in Quantile Regression

Open gmartinonQM opened this issue 1 year ago • 1 comments

I am trying to get reproducible results with MapieQuantileRegressor with the "split" method. Unfortunately :

TypeError: MapieQuantileRegressor.__init__() got an unexpected keyword argument 'random_state'

Whereas the attribute random_state is indeed used in the code of MapieQuantileRegressor, but always with the default value None. (https://github.com/scikit-learn-contrib/MAPIE/blob/2681b82dddbbdc59c3c30abd1de4e3d9a8f00935/mapie/regression/quantile_regression.py#L391)

Could you please add the random_state in the constructor of MapieQuantileRegressor ?

gmartinonQM avatar Jan 25 '24 10:01 gmartinonQM

Hi @gmartinonQM, thank you for this information. If you want replicable results for the moment, I would suggest using the random_state in the .fit method. However, this is indeed something we should change to have it in the .__init__() of the method. Thank you!

LacombeLouis avatar Jan 26 '24 12:01 LacombeLouis