MAPIE icon indicating copy to clipboard operation
MAPIE copied to clipboard

UPD: change configuration project

Open thibaultcordier opened this issue 1 year ago • 2 comments

Description

This configures the pre-commit functionnality: when you prepare a commit, it will automatically run default pre-commit checks and run black and flake8 checks.

Fixes #(issue)

Type of change

  • Configuration files
  • pre-commit => change code style

Checklist

  • [x] I have read the contributing guidelines
  • [x] I have updated the HISTORY.rst and AUTHORS.rst files
  • [x] Linting passes successfully : make lint
  • [x] Typing passes successfully : make type-check
  • [x] Unit tests pass successfully : make tests
  • [x] Coverage is 100% : make coverage
  • [x] Documentation builds successfully : make doc

thibaultcordier avatar Sep 22 '23 08:09 thibaultcordier

If it looks ok to you, then I merge. What tracks so you can see the real additions :

  • .flake8 (https://github.com/scikit-learn-contrib/MAPIE/pull/363/files#diff-6951dbb399883798a226c1fb496fdb4183b1ab48865e75eddecf6ceb6cf46442)
  • test.yml (https://github.com/scikit-learn-contrib/MAPIE/pull/363/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88)
  • .pre-commit-config.yaml (https://github.com/scikit-learn-contrib/MAPIE/pull/363/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9)
  • environment.*.yml
  • mypy.ini (https://github.com/scikit-learn-contrib/MAPIE/pull/363/files#diff-6f2d4ba9ca9a357d31014946667b7bed1bfdbc6d2530afc77778fa0a36bee457)
  • setup.py (https://github.com/scikit-learn-contrib/MAPIE/pull/363/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7)

To cut a long story short, these modifications automate code formatting during commits, reduce testing during push/pull_request, import only the packages needed according to dev/ci/doc and reduce mapie dependencies to the minimum. The rest of the changes are just formatting with the black package.

thibaultcordier avatar Sep 22 '23 10:09 thibaultcordier