MAPIE
MAPIE copied to clipboard
ENH: Adapt the split and cross strategies to quantile regression class
Description
At the moment, conformalized quantile regression has only been implemented with the split-conformal strategy. It would be worth extending it to cross-CQR with the cv
argument. This PR proposes to adapt the quantile regression class for split and cross conformal strategies by adding to the init
method the cv
parameter so that it is comparable to the regression class.
Fixes #200
Type of change
Please remove options that are irrelevant.
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
- [x] Uniformisation of regression tests (for cross settings).
- [x] Adaptation of quantile regression tests to changes.
Checklist
- [x] I have read the contributing guidelines
- [x] I have updated the HISTORY.rst and AUTHORS.rst files
- [x] Linting passes successfully :
make lint
- [x] Typing passes successfully :
make type-check
- [x] Unit tests pass successfully :
make tests
- [x] Coverage is 100% :
make coverage
- [x] Documentation builds successfully :
make doc
Codecov Report
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
963bb6e
) 100.00% compared to head (3f6500b
) 100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 3474 3399 -75
Branches 360 367 +7
=========================================
- Hits 3474 3399 -75
Impacted Files | Coverage Δ | |
---|---|---|
mapie/tests/test_utils.py | 100.00% <ø> (ø) |
|
mapie/utils.py | 100.00% <ø> (ø) |
|
mapie/quantile_regression.py | 100.00% <100.00%> (ø) |
|
mapie/regression.py | 100.00% <100.00%> (ø) |
|
mapie/tests/test_quantile_regression.py | 100.00% <100.00%> (ø) |
|
mapie/tests/test_regression.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.