MAPIE icon indicating copy to clipboard operation
MAPIE copied to clipboard

prefit for CQR

Open LacombeLouis opened this issue 2 years ago • 1 comments

Description

Providing a cv == "prefit option for the CQR. This means adding some additional tests and trusting the user to correctly set the quantiles for their method. This is to fix issue #213.

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Re-create the paper by using the algorithms used in his paper and use them prefit.

Checklist

  • [ ] I have read the contributing guidelines
  • [ ] I have updated the HISTORY.rst and AUTHORS.rst files
  • [ ] Linting passes successfully : make lint
  • [ ] Typing passes successfully : make type-check
  • [ ] Unit tests pass successfully : make tests
  • [ ] Coverage is 100% : make coverage
  • [ ] Documentation builds successfully : make doc

LacombeLouis avatar Aug 01 '22 09:08 LacombeLouis

Codecov Report

Base: 99.77% // Head: 100.00% // Increases project coverage by +0.22% :tada:

Coverage data is based on head (fb88e2a) compared to base (04a4555). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #214      +/-   ##
===========================================
+ Coverage   99.77%   100.00%   +0.22%     
===========================================
  Files          24        24              
  Lines        2188      2290     +102     
  Branches      241       253      +12     
===========================================
+ Hits         2183      2290     +107     
+ Misses          4         0       -4     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
mapie/quantile_regression.py 100.00% <100.00%> (ø)
mapie/regression.py 100.00% <100.00%> (ø)
mapie/tests/test_quantile_regression.py 100.00% <100.00%> (ø)
mapie/tests/test_utils.py 100.00% <100.00%> (ø)
mapie/utils.py 100.00% <100.00%> (ø)
mapie/_compatibility.py 100.00% <0.00%> (+27.77%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 01 '22 09:08 codecov-commenter