MAPIE icon indicating copy to clipboard operation
MAPIE copied to clipboard

Add Covariate Shift Conformal Regressor

Open RudrakshTuwani opened this issue 3 years ago • 7 comments

Description

Add covariate shift conformal method (https://arxiv.org/abs/1904.06019) to MAPIE for regression.

Fixes #72

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Reproducing the results of the original paper.

Checklist

  • [x] I have read the contributing guidelines
  • [ ] I have updated the HISTORY.rst and AUTHORS.rst files
  • [x] Linting passes successfully : make lint
  • [ ] Typing passes successfully : make type-check
  • [ ] Unit tests pass successfully : make tests
  • [ ] Coverage is 100% : make coverage
  • [ ] Documentation builds successfully : make doc

RudrakshTuwani avatar Mar 30 '22 10:03 RudrakshTuwani

Hey @gmartinonQM, please let me know how to prioritize tasks and would really appreciate feedback. Thanks! :)

RudrakshTuwani avatar Mar 30 '22 12:03 RudrakshTuwani

Thanks for the PR @RudrakshTuwani , for sure. Maybe we will take several days to discuss it internally. Stay tuned !

gmartinonQM avatar Mar 30 '22 12:03 gmartinonQM

Hi @RudrakshTuwani , thank you very much for the PR ! The implementation and the notebook look really great. I am sorry for the delay of our feedback, we have been quite busy during the last past weeks. Before giving you a more thorough feedback by next week, just a few general comments :

  • please move the class MapieCovShiftRegressor in a dedicated module (like covariate_shift_regression.py)
  • please move your notebook in the notebooks/regression folder. An alternative is to create a notebook-like example from a .py script like in this example.

vtaquet avatar May 06 '22 19:05 vtaquet

Hello @vtaquet , thank you for getting back to me! No worries about the delay! :)

RudrakshTuwani avatar May 09 '22 22:05 RudrakshTuwani

Couldn't push to @vtaquet 's branch, so pulled the changes to the fork and re-opened PR. Still a WIP!

RudrakshTuwani avatar Aug 29 '22 15:08 RudrakshTuwani

Thanks for the feedback! I will try to address the comments over the weekend. :)

RudrakshTuwani avatar Mar 14 '23 10:03 RudrakshTuwani