WIP: Update notebooks for EuroSciPy 2022
Addresses some deprecation in and before v0.19 as well as other (minor) updates. We plan to use the lectures 00_images_are_arrays, 1_image_filters and 4_segmentation so these are mainly tested and addressed here. Agenda below:
- [ ] lectures
- [x] 00_images_are_arrays circle -> disc
- [x] 3_morphological
skdemo.imshow_all(image, morphology.erosion(image, sq), shape=(1, 2))AttributeError: 'AxesImage' object has no property 'shape' - [x] 4_segmentation DeprecationWarning:
np.int - [ ] 4_segmentation UserWarning: The probability range is outside [0, 1] given the tolerance
prob_tol. Consider decreasingbetaand/or decreasingtol. - [ ] 4_segmentation
active_contourdoesn't really fit head - [x] 5_tophat FutureWarning:
selemis a deprecated argument name forclosing. It will be removed in version 1.0. Please usefootprintinstead. - [x] 6_watershed FutureWarning:
selemis a deprecated argument name fordilation.
- [ ] solutions
- [x] 00_images circle -> disc
- [x] 1_images_filters ConvergenceWarning: lbfgs failed to converge (status=1): STOP: TOTAL NO. of ITERATIONS REACHED LIMIT.
- [x] 1_images_filters "Take a look at this neat feature merged last year:"
- [ ] 4_segmentation
active_contourdoesn't really fit head
- [ ]
check_setup.pyfails withValueError: not enough values to unpack (expected 3, got 1)because new dependencies got added for the jupyter-book stuff -> clashes with tutorial
cc @emmanuelle
Hello @lagru! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2022-08-07 15:53:26 UTC
Thank you @lagru! Looks good to me, so merging.
Hey @emmanuelle, thanks for taking a look at the already included fixes and updates. However, this wasn't yet complete. I think I forgot to mark this as WIP via GitHub's interface. There are still open issues with
- 4_segmentation UserWarning: The probability range is outside [0, 1] given the tolerance prob_tol. Consider decreasing beta and/or decreasing tol.
- 4_segmentation active_contour doesn't really fit head
We already talked at the meeting about the second point but I haven't looked to deply into the UserWarning yet. I will continue this in a new PR.