scikit-image icon indicating copy to clipboard operation
scikit-image copied to clipboard

Docstring of `color.hsv_value` is incomplete

Open lagru opened this issue 2 years ago • 4 comments

Description

color.hsv_value is incomplete:

https://github.com/scikit-image/scikit-image/blob/09577eddf2ce0376b25b96291599af313adb1c2d/skimage/color/adapt_rgb.py#L48-L59

args and kwargs should be documented as well as the return value. It could also be made clearer that image expects an RGB(A) image.

lagru avatar Dec 17 '23 14:12 lagru

Additionally, this function isn't part of skimage.colors API even though the gallery example plot_adapt_rgb hints that is should be.

lagru avatar Dec 17 '23 14:12 lagru

Hi @lagru Please can I take on this if it was not resolved.

davidemusi avatar Dec 29 '23 09:12 davidemusi

Hey @davidemusi, thanks for asking and offering your help. However, this is already worked on in #7277. If you would like, you could try to help that one along. :)

lagru avatar Dec 29 '23 11:12 lagru

Hello scikit-image core devs! There hasn't been any activity on this issue for more than 180 days. I have marked it as "dormant" to make it easy to find. To our contributors, thank you for your contribution and apologies if this issue fell through the cracks! Hopefully this ping will help bring some fresh attention to the issue. If you need help, you can always reach out on our forum If you think that this issue is no longer relevant, you may close it, or we may do it at some point (either way, it will be done manually).

github-actions[bot] avatar Jun 27 '24 02:06 github-actions[bot]