scikit-image icon indicating copy to clipboard operation
scikit-image copied to clipboard

Screen for sphinx warnings in nightly CI jobs

Open lagru opened this issue 2 years ago • 5 comments

Description

... instead of on Azure. I feel like this is the better place to catch warnings early.

The failure addressed by https://github.com/scikit-image/scikit-image/pull/7226 prompted this change.

Checklist

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The summary will be included in the next release notes automatically:

...

lagru avatar Oct 27 '23 19:10 lagru

I think this would be an improvement. But who gets notified of nightly failures, and how?

stefanv avatar Oct 27 '23 20:10 stefanv

But who gets notified of nightly failures, and how?

The "Test Nightly" job is triggered on pushes to main. So the core dev creating the merge should be notified explicitly. And a failure should be somewhat visible on our main GitHub page.

It's not ideal but I think we discussed this problem somewhere earlier and found this to be the best solution. We could look into creating an issue automatically on failure?

lagru avatar Oct 29 '23 16:10 lagru

Yes, I think that's the solution!

stefanv avatar Oct 29 '23 16:10 stefanv

Yes, I think that's the solution!

Which one? The "raise an issue" one?

lagru avatar Oct 29 '23 17:10 lagru

Yes, because I don't think the notification route is very clear otherwise.

stefanv avatar Oct 29 '23 17:10 stefanv