pyhf icon indicating copy to clipboard operation
pyhf copied to clipboard

lumi schema & name property

Open andrewfowlie opened this issue 5 months ago • 0 comments

I was looking at the schema, trying to understand which elements are required etc. I noticed that the lumi modifier schema gives the name as well as the type to be { "const": "lumi" }

https://github.com/scikit-hep/pyhf/blob/3d26434be836050e334190c212b1db1a6f7650c8/src/pyhf/schemas/1.0.0/defs.json#L115-L122

If I understand this correctly, it says that all lumi modifiers must be called lumi.

Compare this to other modifiers e.g., shapesys.

https://github.com/scikit-hep/pyhf/blob/3d26434be836050e334190c212b1db1a6f7650c8/src/pyhf/schemas/1.0.0/defs.json#L165-L170

here, it seems like the name can be any string you want.

Do I understand this correctly? Is this lumi restriction deliberate so that there can only ever be a single lumi modifier named lumi? This kind of makes sense, although I could imagine wanting to have different lumi modifiers, especially if I was including both ATLAS and CMS data. Or is it a copy-paste error since it is the same as the line below it?

andrewfowlie avatar Sep 24 '24 13:09 andrewfowlie