fix: Catch invalid model specification with duplicate channels, samples and modifiers.
Description
Fixes #2059 but extends to channels and samples. We want to catch the case where we have multiple channels with the same name in the model specification, where the first of these would simply be ignored as of now. Similarly, this applies to samples with the same name in a given channel or modifiers with the same name and type in a given sample.
Checklist Before Requesting Reviewer
- [x] Tests are passing
- [x] "WIP" removed from the title of the pull request
- [ ] Selected an Assignee for the PR to be responsible for the log summary
Before Merging
For the PR Assignees:
- [ ] Summarize commit messages into a comprehensive review of the PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a1a31f1) 98.28% compared to head (edea8ef) 98.28%. Report is 9 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2396 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 69 69
Lines 4539 4556 +17
Branches 803 814 +11
=======================================
+ Hits 4461 4478 +17
Misses 45 45
Partials 33 33
| Flag | Coverage Δ | |
|---|---|---|
| contrib | 97.87% <100.00%> (+<0.01%) |
:arrow_up: |
| doctest | 60.66% <47.05%> (-0.06%) |
:arrow_down: |
| unittests-3.10 | 96.31% <100.00%> (+0.01%) |
:arrow_up: |
| unittests-3.11 | 96.31% <100.00%> (+0.01%) |
:arrow_up: |
| unittests-3.8 | 96.33% <100.00%> (+0.01%) |
:arrow_up: |
| unittests-3.9 | 96.35% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.