hepstats icon indicating copy to clipboard operation
hepstats copied to clipboard

Published 20 hours ago • verified publisher icon scikit-hep

Bayesian Blocking prior is astro-specific

Open Moelf opened this issue 1 year ago • 1 comments

image

https://github.com/scikit-hep/hepstats/blob/85cdb1e9c0a2699fbe4715ff7c879f068ca7452f/src/hepstats/modeling/bayesian_blocks.py#L53-L54

Moelf avatar Oct 24 '22 20:10 Moelf

https://arxiv.org/pdf/1304.2818.pdf should probably use this, the 2012 has wrong formula

Moelf avatar Oct 24 '22 20:10 Moelf

Thanks @Moelf for the comment! You are most welcome to submit a PR otherwise we will get to this asap.

eduardo-rodrigues avatar Oct 25 '22 16:10 eduardo-rodrigues

no sorry I think you guys already used the correct formula, but I think now the problem is we shouldn't default to the prior one anyway, we should use the geometric prior, because the formula in screen shot comes from fitting astrophysics data, our histograms have nothing to do with brightness sequence of stars

Moelf avatar Oct 25 '22 16:10 Moelf

Hi @Moelf , I am myself not an expert in this, however it's not quite clear to me why a geometric prior should be used? But as @eduardo-rodrigues mentioned, you're very welcome to open a PR and we can discuss it there (I have too little time currently to dig deep enough into the topic).

jonas-eschle avatar Oct 31 '22 11:10 jonas-eschle

Because the prior and numbers you're currently using is derived from fitting a simulation of star light, nothing to do with HEP

Moelf avatar Oct 31 '22 12:10 Moelf