cabinetry icon indicating copy to clipboard operation
cabinetry copied to clipboard

fix: respect fixed parameters in n_dof calculation

Open lorenzennio opened this issue 1 year ago • 1 comments

Solves #478 by passing fixed parameters to model_utils.unconstrained_parameter_count.

lorenzennio avatar May 30 '24 16:05 lorenzennio

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (19ce6a1) to head (0a379af). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #479   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2094      2096    +2     
  Branches       347       347           
=========================================
+ Hits          2094      2096    +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 30 '24 17:05 codecov[bot]

Hi @alexander-held, I think this is ready and non-breaking change, unless you did tests which hint otherwise?

MoAly98 avatar Feb 28 '25 14:02 MoAly98