awkward icon indicating copy to clipboard operation
awkward copied to clipboard

ci: add 3.13 wheels

Open henryiii opened this issue 1 year ago • 1 comments

Adding 3.13 (non-free-threaded at the moment).

henryiii avatar Aug 15 '24 15:08 henryiii

  E       AssertionError: Regex pattern did not match.
  E        Regex: "Can't pickle"
  E        Input: "Can't get local object 'test_serialise_with_nonserialisable_attrs.<locals>.<lambda>'"

henryiii avatar Aug 15 '24 15:08 henryiii

@henryiii "cp313", "cp313t" are now available and numpy is also (as of a few hours ago) producing 3.13t wheels as well. Worth another try now!

lgray avatar Sep 03 '24 17:09 lgray

Passing.

henryiii avatar Sep 03 '24 21:09 henryiii

Guessing because of cramjam workaround we presently cannot test 3.13t?

lgray avatar Sep 03 '24 22:09 lgray

3.13 works with the workaround. Either cramjam happens to work with it or we don’t use enough of it to be affected by any breakage.

3.13t probably not.

henryiii avatar Sep 04 '24 02:09 henryiii

Ah, yes, you have the t.

henryiii avatar Sep 04 '24 02:09 henryiii

Where do you see it in the tests? Or are you saying I'm asking for it and we don't have it? If the latter, I guess we just wait a bit for setup-python to make a release.

lgray avatar Sep 04 '24 04:09 lgray

We aren't building 3.13t yet in cibuildwheel, so it's not built or tested. I'm assuming there's no chance this workaround works on 3.13t; I'm not even sure PyO3 main supports 3.13t yet.

For PyO3 (current, not old version), see https://github.com/Quansight-Labs/free-threaded-compatibility/issues/53.

henryiii avatar Sep 04 '24 05:09 henryiii

FYI https://github.com/milesgranger/cramjam/releases/tag/v2.8.4-rc3

lgray avatar Sep 05 '24 22:09 lgray

All the tests that this PR branch runs are now required, and nothing that it doesn't run is required. Now I'll update and auto-merge.

jpivarski avatar Sep 12 '24 17:09 jpivarski