awkward icon indicating copy to clipboard operation
awkward copied to clipboard

chore: update CITATION.cff

Open agoose77 opened this issue 2 years ago • 1 comments

Addresses #1713

agoose77 avatar Sep 22 '22 14:09 agoose77

Codecov Report

Merging #1717 (6076c14) into main (e692946) will increase coverage by 0.38%. The diff coverage is 84.98%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_v2/_connect/jax/__init__.py 90.47% <ø> (+1.58%) :arrow_up:
src/awkward/_v2/config.py 0.00% <0.00%> (ø)
src/awkward/_v2/operations/ak_broadcast_arrays.py 100.00% <ø> (+4.34%) :arrow_up:
src/awkward/_v2/operations/ak_transform.py 65.51% <ø> (+56.89%) :arrow_up:
src/awkward/_v2/types/uniontype.py 84.61% <ø> (ø)
src/awkward/_v2/behaviors/categorical.py 73.13% <60.00%> (-8.94%) :arrow_down:
src/awkward/_v2/contents/bitmaskedarray.py 71.42% <60.00%> (-0.11%) :arrow_down:
src/awkward/_v2/contents/bytemaskedarray.py 88.32% <60.00%> (-0.03%) :arrow_down:
src/awkward/_v2/contents/listarray.py 91.89% <60.00%> (-0.02%) :arrow_down:
src/awkward/_v2/contents/unmaskedarray.py 70.76% <60.00%> (-0.13%) :arrow_down:
... and 56 more

codecov[bot] avatar Sep 22 '22 14:09 codecov[bot]

To answer your question from issue #1713, yes, Manasvi definitely qualifies as an author and I think she should be added to the list.

Is this good with you, @ManasviGoyal? Would you prefer a different email and do you have an ORCID? If you don't have an ORCID, it's easy to set one up: https://orcid.org/ This is a unique identifier that links all of your academic publications.

jpivarski avatar Sep 22 '22 15:09 jpivarski

To answer your question from issue #1713, yes, Manasvi definitely qualifies as an author and I think she should be added to the list.

Is this good with you, @ManasviGoyal? Would you prefer a different email and do you have an ORCID? If you don't have an ORCID, it's easy to set one up: https://orcid.org/ This is a unique identifier that links all of your academic publications.

Yes, @jpivarski this email works. I have set up an ORCID. here is the link - https://orcid.org/0000-0001-6321-7491. @agoose77 please add this too. Thanks.

ManasviGoyal avatar Sep 22 '22 16:09 ManasviGoyal

Great! Then I'll merge the new author list.

jpivarski avatar Sep 23 '22 00:09 jpivarski

@agoose77 I was checking the doi link and noticed that the authors and the commits on zenodo are not up to date with the changes made to the CITATION.cff. Just wanted to bring it to your notice if it's something unusual. Thanks.

ManasviGoyal avatar Sep 24 '22 00:09 ManasviGoyal

I believe the Zenodo information will update when we next make a release, right @jpivarski?

agoose77 avatar Sep 24 '22 13:09 agoose77

Yes, that's correct. I discovered it experimentally yesterday with Uproot: adding a CITATION.cff when there hasn't been one before had no effect on Zenodo until I made a release. Uproot releases take a few minutes to make, but Awkward takes 4 hours, though maybe that will be a bit less (1 hour?) with v1 dropped. We'll be making such a release soon, and I can make sure to tell you when that happens.

jpivarski avatar Sep 24 '22 13:09 jpivarski