jgo
jgo copied to clipboard
Sort jars before searching for mainClass
Fixes https://github.com/scijava/jgo/issues/90
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.68%. Comparing base (
89d20d1) to head (07c9a90). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 94.53% 94.68% +0.14%
==========================================
Files 6 6
Lines 879 903 +24
==========================================
+ Hits 831 855 +24
Misses 48 48
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ping @ctrueden . I would like to see this merged as py2many currently depends on it for its Kotlin support. c.f. https://github.com/py2many/py2many/blob/main/tox.ini#L31
I would like to do a release soon with a released jgo added as a dependency
@jayvdb Thanks very much for digging into this and providing a fix. Your solution is succinct and clever. It bothers me that we don't just ask Maven directly for the actual filename of the primary endpoint somehow; but I cannot immediately come up with a concrete example where the sort fails to do the right thing (maybe something with classifiers? but it's a vanishingly small fraction of use cases). So let's just go for it!