scientific-python.org icon indicating copy to clipboard operation
scientific-python.org copied to clipboard

Feat search

Open Bashamega opened this issue 1 year ago • 9 comments

Fix #673 I have added the search input

Bashamega avatar Mar 08 '25 07:03 Bashamega

Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name Link
Latest commit c010a9687abd2abfc6b3358deb6b4c7a1f614223
Latest deploy log https://app.netlify.com/sites/scientific-python-org/deploys/67d115db85063c0008bfb2d6
Deploy Preview https://deploy-preview-735--scientific-python-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 97
Accessibility: 100
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 08 '25 07:03 netlify[bot]

pre-commit.ci autofix

Bashamega avatar Mar 08 '25 08:03 Bashamega

Can you use the theme search feature?

jarrodmillman avatar Mar 09 '25 07:03 jarrodmillman

Can you use the theme search feature?

Sure, thank you for your help

Bashamega avatar Mar 09 '25 08:03 Bashamega

Hello @jarrodmillman Thank you so much for the linked pr, it has helped me solve the issue. The build is now working. Please review and merge

Bashamega avatar Mar 09 '25 10:03 Bashamega

You should use the css and javascript from the theme. If you need improvements, it should be done there. I also don't think you need to edit the netlify config.

jarrodmillman avatar Mar 10 '25 14:03 jarrodmillman

You should use the css and javascript from the theme. If you need improvements, it should be done there. I also don't think you need to edit the netlify config.

I need to add the NODE to the netlify environment to install the pagfind library.

Bashamega avatar Mar 10 '25 14:03 Bashamega

You should use the css and javascript from the theme. If you need improvements, it should be done there. I also don't think you need to edit the netlify config.

I need to add the NODE to the netlify environment to install the pagfind library.

We are already using Node 20.

jarrodmillman avatar Mar 11 '25 00:03 jarrodmillman

Hello @jarrodmillman, and @stefanv I have updated the Makefile as requested

Bashamega avatar Mar 12 '25 05:03 Bashamega