clojisr icon indicating copy to clipboard operation
clojisr copied to clipboard

Published 20 hours ago • verified publisher icon scicloj

Lazy r defs

Open behrica opened this issue 1 year ago • 9 comments

got the simple unary / binary functions "r_xxx" working

behrica avatar May 07 '24 17:05 behrica

now as well the str-md

behrica avatar May 07 '24 18:05 behrica

I think I made all "lazy", keeping full functionality. running clj src/clojisr/v1/r.clj does not trigger initialize R any more, so namespace can be required and does not try to connect to R. I made tests for all functions and they keep passing.

behrica avatar May 07 '24 20:05 behrica

Wow! You've made a great job! Thanks. I'll take a look at this today.

genmeblog avatar May 08 '24 07:05 genmeblog

lates commit https://github.com/scicloj/clojisr/pull/99/commits/c952bed0f66028d1b58b3b84c442b70995ee6895 here fixes as well #96

behrica avatar May 08 '24 15:05 behrica

Where is the code which defines x %% y x %/% y %in% ?

Its mentioned in CHANGELOG, but cannot find it

behrica avatar May 10 '24 15:05 behrica

Where is the code which defines x %% y x %/% y %in% ?

Its mentioned in CHANGELOG, but cannot find it

I don't remember precisely, maybe it was done in codegen. I need to verify this.

genmeblog avatar May 10 '24 16:05 genmeblog

I'll review this today.

genmeblog avatar May 28 '24 08:05 genmeblog

@genmeblog any progress on the review of this PR ?

behrica avatar Sep 21 '24 19:09 behrica

Oh, thanks for the reminder. I believe I've tested it locally and everything worked. But it was 4 months ago.

genmeblog avatar Sep 22 '24 18:09 genmeblog

is this ready to be merged ?

behrica avatar Jan 14 '25 19:01 behrica