clay icon indicating copy to clipboard operation
clay copied to clipboard

minor problem browsing the docs

Open blnote opened this issue 1 year ago • 4 comments

Hey, I really like the project! Just a minor issue with the documentation at https://scicloj.github.io/clay (don't know if it is the right place here ?) I find it kind of hard to browse because when pressing the up/down arrow keys it scrolls to the embedded portal-visualization and focuses it - no matter where I am on the page. May be a browser issue (I'm using Brave), but also occurs in Edge.

Further in both browsers and on mobile I find the headers hard to read in dark-mode clay

I'm happy to help if needed, best regards!

blnote avatar Jan 23 '24 15:01 blnote

@blnote many thanks, this is very helpful.

Yes, Portal is indeed capturing key bindings of the whole page at the moment. Yesterday on a discussion with Portal's creator @djblue, I wondered whether this was actually a usability problem. It helps to know that it is noticable on your side.

Also thanks for noticing the problem with headers in dark-mode, I haven't figured that out yet.

daslu avatar Jan 23 '24 19:01 daslu

Good news: The font colour problems seem to be caused by the embedded Portal as well. With no Portal viewers embedded, the colours are ok.

daslu avatar Jan 23 '24 22:01 daslu

Link to Slack #portal discussion: https://clojurians.slack.com/archives/C0185BFLLSE/p1705829969607509

daslu avatar Jan 23 '24 22:01 daslu

The dark mode problem seems to be solved in version "2-alpha76" (relying on a temporary pre-release build of Portal). The keyboard problem remains for now.

daslu avatar Jan 27 '24 22:01 daslu