fping
fping copied to clipboard
Regularly print full instead of interval stats with -Q SECS -F (--squiet=SECS --full)
This is a proof-of-concept implementation for the feature requested in issue #243.
Coverage increased (+1.0%) to 80.687% when pulling bc56274967298d0357f57ea0df26280beacd43bd on auerswal:no-split-stats into 3ecfbb7c1e1743c6cda3bf270a88eedcb2e292f8 on schweikert:develop.
I think the coveralls test is not completely accurate, since it includes lower test coverage for the files src/socket4.c
and src/socket6.c
that are not touched by this pull request. I did not remove any tests either.
But it correctly mentions that not all new lines are covered by tests. I'll add more commits to this pull request shortly to partially address this by adding tests for the option combinations -Q -o
and -Q -F -o
. The other new lines pertain to receiving more Echo Replies than Echo Requests sent and are thus not easily testable.
I'll look into making the tests less timing critical to address the macOS test failure. This a problem in the test, the output is as expected for an RTT > 100ms, but I did not expect such a long RTT for localhost
(on my local GNU/Linux test system localhost
RTT is reliably < 100ms). I'll amend the pull request shortly.
Is there any interest in this work?
Closing this pull request due to lack of interest in this work.
Erik, sorry for the frustrating experience due to my lack of response. I feel like I failed as a maintainer of this project :-( I would still like to keep this PR open (and the others), if you agree. I do expect to get some time to work again on fping.
David, I understand that you can have a limited amount of available time and motivation for maintaining open-source projects. It is the same for me. I still have the code, so this work is not lost, even though I have deleted my fping fork and closed the pull requests.
Feel free to contact me if and when you do have both sufficient time and motivation to work on any of this. I'd be happy to update the patch series to the future fping code and create fresh pull requests then, but I do not like to have an old and stale forked repo in my GitHub account.