fping icon indicating copy to clipboard operation
fping copied to clipboard

Published 20 hours ago • verified publisher icon schweikert

Deal with multiple fping processes with colliding ICMP idents getting wrong echo reply

Open clarsen opened this issue 4 years ago • 3 comments

Fix for https://github.com/schweikert/fping/issues/206. It's a slow linear search, but more simple is more correct.

clarsen avatar Nov 25 '20 22:11 clarsen

Coverage Status

Coverage increased (+0.1%) to 81.098% when pulling 6c7bdb12b479d10333210896fe51b61693a350f6 on clarsen:fix_spurious_response into eac20347bac9aa396fa1c2039c57e7603862e6cc on schweikert:develop.

coveralls avatar Nov 25 '20 23:11 coveralls

Bump on this pull request...

clarsen avatar May 31 '22 17:05 clarsen

I see multiple issues with this PR:

  • The code is doing a linear search, so this could be impacting performance in a bad way
  • fping does on purprose not make the assumption tha the source address of the reply matches the destination of the echo request

schweikert avatar Jun 26 '22 17:06 schweikert