fping-exporter icon indicating copy to clipboard operation
fping-exporter copied to clipboard

Possibility to add more args and generate a logfile

Open oijkn opened this issue 5 years ago • 2 comments

Hi,

Could you add the "-B", "-r", "-i" and "-t" options, please ? Could you also add an option to generate a logfile, please ?

Thanks in advance for your support.

oijkn avatar May 01 '20 16:05 oijkn

Also the adjustment for the calculation for the fping -p option would be nice.

worker.go: "-p", // period fmt.Sprintf("%.0f", w.spec.period.Seconds()*500/float64(w.spec.count))

the factor 500 instead of 1000 (for milliseconds) distributes the number of packets only for half of the exporter time. For every 60 seconds, only 30 seconds are used to probe. An adjustable factor could be nice to distributed the ping probes within the 60sec. Was there any specific idea why it is set to 500?

LukeSiX avatar Jun 10 '20 10:06 LukeSiX

-B (--backoff) and -r (--retry) don't make sense with -p (--period), which is what fping-exporter uses. -t (--timeout) might not be very useful, because it is auto-tuned to the period (up to 2s), which is supposed to matching prometheus probing interval, and is assumed not to be smaller than 2s. -i: yes, this one should be tunable.

schweikert avatar Aug 06 '20 04:08 schweikert