ics-openvpn
ics-openvpn copied to clipboard
schwabe
Spelling
Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn
Note: Normally I exclude localizations. The only reason they're included is that I was migrating these changes from ProtonVPN/android-app#8 and hadn't excluded them yet. I'm happy to drop them if requested.
I try to exclude third party content. If I've missed something, please let me know, and if possible direct me to its upstream.
I think changing spelling mistakes in licenses is wrong. The commits modify the openssl license.
As a sidenote. 85 commits for the spelling is a lot. I will probably squash a few of them together before merging (unless you do it first).
Changing the localization keys will invalidate all the localisations in crowdin locatisation service. I am not sure if that is worth fixing the spelling mistakes. Have to think about that.
I can split that out to a distinct PR or however you request. I leave them as distinct commits while working on them because it makes it easier to drop things as a set (e.g. if i needed to drop the slider changes because you objected).
squashing/etc. is totally up to the project, I'm fairly flexible. I won't squash until (a) the build is green and (b) you're happy w/ things -- as it's fairly hard to unsquash, but trivial to squash...
ok, this is green. Let me know what you need done, and I can look into doing it (probably Tuesday).