Stephen Chung

Results 552 comments of Stephen Chung

> my main worry were collection types since they seem to use Dynamic, meaning a lot of cache misses for any sort of collection type Why? You mean a collection...

Well, any collection of trait objects will necessarily involve allocations and redirections. You can register a special collection type that holds just a particular type, plus an API to access...

Nevertheless, I would caution that allocations does not necessarily equate cache misses. Modern memory allocators try to put similarly-sized allocations close to each other. You may find that your array...

I regularly run these just to flush out warnings. However probably a bit heavy yo have inside the library as default.

> I would also be interested in seeing this PR getting merged at some point. It looks like it would work perfectly for my use case. Anything I can do...

Rebinding the Escape key works fine (you essentially make it the same as Ctrl-U) and behaves similarly to the command prompt on Windows -- you're probably running Windows if you...

> But with Windows Terminal, you may have the same issue as on unix if we activate `ENABLE_VIRTUAL_TERMINAL_INPUT`... Probably yes, but without `ENABLE_VIRTUAL_TERMINAL_INPUT`, I have mapped Esc to clear-line like...

I think Escape is treated differently. You have to bind via: ```rust KeyEvent::KeySeq(smallvec![KeyEvent(KeyCode::Esc, Modifiers::empty())]) ``` `KeyEvent::new` is only for ASCII.

Got the same error re no Windows 8.1 SDK. Does it depend on C++ being installed with VS 2015 to get the Windows SDK? Or maybe we should simply install...

My suggestion is that unsigned is usually only needed in order to encode the "non-negative" constraint in code. Otherwise, it can just as easily be solved via "bigint" as suggested...