p2.js icon indicating copy to clipboard operation
p2.js copied to clipboard

npm finds 119 vulnerabilities on install

Open oatkiller opened this issue 4 years ago • 5 comments

image

I'm going to take a crack at fixing this unless I'm told not to.

P.S. Thanks for the cool library

oatkiller avatar Nov 16 '19 18:11 oatkiller

@schteppe I can get rid of 10 vulnerabilities by swapping in grunt-jsdoc in place of grunt-contrib-yuidoc. Any objection? The docs look prettier similar:

Before

image

After

image

No doubt there are minor issues with this swap, but I think the vulnerabilities are a bigger deal.

Only 109 now image

oatkiller avatar Nov 16 '19 19:11 oatkiller

@schteppe The next big issue is nodeunit. I'm going to take a stab at replacing it w/ jest. My reasoning is simple: lots of people use jest and most modern JS testing frameworks are largely the same. Any objections there?

oatkiller avatar Nov 16 '19 19:11 oatkiller

Good job on having so many tests :) I'm making some progress moving things to jest, but it could take a while. I'll follow up when I get those vulnerabilities to 0.

oatkiller avatar Nov 17 '19 04:11 oatkiller

Still working through porting the tests to jest. I'll get there. Please let me know if this work is something you'll be willing to consider merging.

oatkiller avatar Nov 21 '19 17:11 oatkiller

I appreciate this work! I have no idea if @schteppe plans on supporting p2.js any more. It's difficult work and this project has been pretty silent for the path few years.

jtenner avatar Nov 21 '19 17:11 jtenner