fixed-data-table-2 icon indicating copy to clipboard operation
fixed-data-table-2 copied to clipboard

Resizing columns with touch scrolls page vertically

Open marhaupt opened this issue 5 years ago • 3 comments

When resizing columns on touch device scrolls vertically whole page and throws error [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080

Expected Behavior

The page doesn't move and only column resizes if you drag resize handle.

Steps to Reproduce

Can be reproduced even in desktop chrome in devtools using example by trying to resize collumns on responsive version of site.

Your Environment

Tested on Chrome 79 and above on Windows 10, probably happened before. Happens also on Android versions of Chrome and Firefox.

marhaupt avatar Jan 09 '20 12:01 marhaupt

The underyling issue is that of #407. We fixed it for table scrolling by manually adding "active" event listeners (see #422). We'll likely need to do the same here for the touch handlers in FixedDataTableCell, or wait until React provides a way to specify the passiveness of the event listeners.

pradeepnschrodinger avatar Jan 20 '20 11:01 pradeepnschrodinger

@nelsonio we're you able to investigate the fix suggested by @pradeepnschrodinger ? If so could you create a PR so we can get it back into the mainline? Thanks

wcjordan avatar Feb 12 '20 16:02 wcjordan

I get the same error when scrolling horizontally on Chrome 80

mirko77 avatar Mar 12 '20 17:03 mirko77