coordgenlibs icon indicating copy to clipboard operation
coordgenlibs copied to clipboard

Code ank2829 issue51

Open CodeAnk2829 opened this issue 1 year ago • 4 comments

Resolve the issue #51 as mentioned

CodeAnk2829 avatar Mar 30 '23 19:03 CodeAnk2829

HI @CodeAnk2829, thanks for your PR. You indeed made the changes suggested in the issue, but as I also mentioned in the issue, since we don't have proper testing in place to make sure these changes don't break the functionality, I'd rather not merge these changes without proper testing.

ricrogz avatar Mar 30 '23 20:03 ricrogz

Thanks @ricrogz for replying. I realized that I have missed something and I will look into the issue again. As of now can you please assign me this issue? because I think I can fix this issue with proper testing.

CodeAnk2829 avatar Mar 31 '23 02:03 CodeAnk2829

Thanks @ricrogz for replying. I realized that I have missed something and I will look into the issue again. As of now can you please assign me this issue? because I think I can fix this issue with proper testing.

@CodeAnk2829, please don't worry about this. The issue was just filed to document a minor problem that doesn't affect the functionality of the library. Like I said, we won't merge any fixes to this issue because don't have any testing infrastructure in place to make sure that a potential fix doesn't break the functionality in an unexpected way. By now, it is not in our priorities to create such testing infrastructure or fix this issue.

ricrogz avatar Mar 31 '23 18:03 ricrogz

Ok @ricrogz, now I understood.

CodeAnk2829 avatar Apr 01 '23 02:04 CodeAnk2829