schreter

Results 76 comments of schreter

Yes, the three metrics make sense. Regarding publishing them, we can make it dependent on whether there is a subscriber or not. As soon as the first subscriber is attached...

I'm following your discussion, since we have a similar problem in our project - we don't want to send unnecessary messages (and we don't even want to send empty ping...

Just yesterday, we discussed it with the colleagues what this means in detail (also for the snapshot, that's similar). In fact, we need a two-stage process: first, the state machine...

Yes, something like that. Simple `Future` won't work, since the `Future` which needs to be deferred to a background task must be `'static`. Further, the implementation may need to await...

> Is it all right to return a ready Future if it can execute the request immediately? > This would make the API simpler. Unless in this way it affects...

I grepped the `tokio` usage in openraft. Here the traits and packages used that need to be possibly abstracted: ``` tokio::io::AsyncRead tokio::io::AsyncReadExt tokio::io::AsyncSeek tokio::io::AsyncSeekExt tokio::io::AsyncWrite tokio::io::AsyncWriteExt tokio::runtime::Runtime tokio::runtime::Runtime::new tokio::select tokio::spawn...

Synchronous mutexes are sometimes in fact preferable (they anyway can't be locked over await). I didn't check where we do have mutexes in openraft, but the one for shutdown state,...

@zicklag I'm contributing stuff to the openraft repo, since we want to use it in our project as well (and want to have it rock-solid and fast). There, it will...

> BTW, to me, geo-replication is quite a big topic. That's why we are not going for it in the first shot :-). Anyway, that's also why we chose the...

@fredfortier We also have a relatively complex snapshot that is not file based. Basically, it is a set of pages to transfer with some meta information regarding page location (since...