ESP32-audioI2S icon indicating copy to clipboard operation
ESP32-audioI2S copied to clipboard

More Vorbis files that won't play

Open ma261065 opened this issue 1 year ago • 4 comments

Hi,

I found two more Vorbis files that won't play, but do play in other players.

https://archive.org/download/gd1982-04-11.sbd.miller.108852.flac16/gd82-04-11d1t02.ogg and https://archive.org/download/gd1978-08-30.s2.sbd.miller.110151.flac16/gd78-08-30d3t03.ogg

Both seem to have the same problem in that there is excessive padding before the third OggS marker.

The third marker is at 0x1800, so the code in VORBISparseOGG(uint8_t *inbuf, int *bytesLeft) that calls VORBIS_specialIndexOf() doesn't find it.

I found that changing the line to: int idx = VORBIS_specialIndexOf(inbuf, "OggS", 8192); allows them to be played.

ma261065 avatar Jan 08 '24 08:01 ma261065

@schreibfaul1 what do you think about these? Is it worth adjusting the code to allow them to play?

ma261065 avatar Feb 01 '24 23:02 ma261065

Oh, I think I missed your issue. I'll have a look at it soon.

schreibfaul1 avatar Feb 02 '24 14:02 schreibfaul1

And another error fixed. Thank you for your support.

schreibfaul1 avatar Feb 02 '24 20:02 schreibfaul1

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Mar 04 '24 02:03 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Mar 19 '24 01:03 github-actions[bot]