NPoco icon indicating copy to clipboard operation
NPoco copied to clipboard

Added Metadata to ColumnInfo which can be accessible from IMapper

Open dario-l opened this issue 1 year ago • 2 comments

Hi @schotime, I would love some feedback on this!

We have builtin solution for encryption by our custom encryption mechanism. We want to map specific properties using FluentMappings but there is no possible to pass additional metadata to the IMapper.

With this update I added Metadata dictionary which can be populated in fluent mappings and can be passed to any IMapper instance.

I will be happy if you accept my pull-request. 😃

dario-l avatar Jun 29 '23 15:06 dario-l

Hey, nice one. like it, however it's a breaking change. And all the formatting changes that make it hard to decipher what you've changed, lol.

Ideally if we can find a way to make this non-breaking that would be great. I have some ideas, but would need to test them out. Happy for you to have a try though.

We actually do the same thing but we wrap all encrypted fields in a class which can then easily be mapped conventionally. Has the benefit of knowing which fields are encrypted just by looking at them.

schotime avatar Jul 04 '23 12:07 schotime

And all the formatting changes that make it hard to decipher what you've changed, lol.

Sorry for that. It's by habit. 😄

Ideally if we can find a way to make this non-breaking that would be great. I have some ideas, but would need to test them out.

Right. Maybe overloaded methods on IMapper will be just enough?

We actually do the same thing but we wrap all encrypted fields in a class which can then easily be mapped conventionally. Has the benefit of knowing which fields are encrypted just by looking at them.

You mean base class or just additional class which maps to special table (for encrypted data) in db?

dario-l avatar Jul 04 '23 13:07 dario-l