croc icon indicating copy to clipboard operation
croc copied to clipboard
Published 2 weeks ago • verified publisher icon schollz

Winget Release Action is broken

Open jathek opened this issue 1 year ago • 2 comments

Describe the bug

The action to release to winget seems broken. It hasn't successfully run for some time (if ever?). The current version on winget is croc 9.6.6.

To Reproduce

Steps to reproduce the behavior:

  1. run winget search croc
  2. version is 9.6.6, expect 9.6.12

Expected behaviour

Winget should have updated croc version.

Version

croc version v9.6.6-1e57206

Additional context

jathek avatar Feb 21 '24 04:02 jathek

Stale issue message

github-actions[bot] avatar Apr 21 '24 12:04 github-actions[bot]

The current release (9.6.15) is on winget, but I assume it was added manually, because the winget action's logs still show authentication errors.

jathek avatar Apr 21 '24 19:04 jathek

I don't maintain winget, please make a PR to fix it

schollz avatar May 20 '24 13:05 schollz

To be clear, the problem is not with winget, it's with the release action on this repo. You don't maintain that? The error logs seem to indicate a 401 error because of bad credentials. According to https://github.com/vedantmgoyal9/winget-releaser/issues/240, it seems like your GitHub PAT needs to be regenerated. I don't think anyone can do that via a PR.

jathek avatar May 25 '24 17:05 jathek

do you have instructions for doing that?

schollz avatar May 25 '24 17:05 schollz

EDIT2: The original PR that added the winget action to this repo lays out the required steps more clearly than I did, please check it out

OLD POST:

According to the readme of winget-releaser, you need to create a classic PAT with public_repo scope. GitHub's instructions for that are here. Afterwards, I assume you will need to copy it into the secrets for this repo and update the secret named WINGET_TOKEN. Instructions for repo secrets are here.

EDIT: After reading the readme for the winget-releaser a bit more, you will also have to fork https://github.com/microsoft/winget-pkgs, as winget-releaser defaults to using a fork on the repo owner's account (Step 2 on Getting Started). It doesn't look like you have a fork on schollz so that will be necessary too.

winget-releaser recommends using https://github.com/apps/pull on the winget-pkgs fork to keep it synced with the upstream. Installing and setting that up is a couple of clicks: you choose the account (schollz) and then you can install it for a specific repository (your fork of winget-pkgs).

jathek avatar May 25 '24 17:05 jathek

thanks.

winget-action is now working: https://github.com/schollz/croc/actions/runs/9236640238

schollz avatar May 25 '24 18:05 schollz

pull is already installed on my winget-pkgs fork btw.

I'll close this issue because winge release action is no longer broken, but please feel free to make another issue if another thing in winget is not working

schollz avatar May 25 '24 18:05 schollz