croc icon indicating copy to clipboard operation
croc copied to clipboard

potential data races

Open 191830230 opened this issue 2 years ago • 2 comments

Hello developer, I used a static data race detector to check this project and found suspicious data race defects. I have done preliminary filtering and categorized the defects, choosing only one from each category. However, due to my unfamiliarity with the overall architecture of the project, there may still be false positives after filtering. Below are the potential data race issues I found(not all stack traces are listed) commit id:3c1d60

Potential race condition: Access1: if err == nil { ^ croc/src/croc/croc.go:635:4 -> croc/src/croc/croc.go:573:8

Access2: err = <-errchan ^ croc/src/croc/croc.go:638:2 Other issues are similar to this one listed, focused on "func (c *Client) Send(filesInfo []FileInfo, emptyFoldersToTransfer []FileInfo, totalNumberFolders int) (err error):515"

191830230 avatar Apr 19 '23 14:04 191830230

Happy to accept a PR to fix.

schollz avatar Apr 19 '23 19:04 schollz

Stale issue message

github-actions[bot] avatar Feb 17 '24 12:02 github-actions[bot]