Zack

icon indicating a website link https://schollz.com icon indicating an email [email protected]

icon location Seattle, WA icon location Software Engineer + Scientist

Results 649 comments of Zack

Using atomics instead of mutexes could improve performance

Would love a PR ! Looks awesome

Using atomics instead of mutexes could improve performance

@rustiever Sure

Using atomics instead of mutexes could improve performance

I think the goal of this PR is for optimization, so if mutex isn't optimal yes

Keep elapsed time when finished

Would accept a PR for this

Add support to also show spinner on non indeterminate

I'd accept a PR for this!

Failing test on non x86 architectures

Can you submit a PR to fix?

Race condition with dynamic max

Could you submit a PR?

Option to leave progress bar visible after finished

Great! Would happily accept PR with this

Option to leave progress bar visible after finished

@ibraimgm of course!

Option to leave progress bar visible after finished

@vidu171 Its open, go ahead!