Jan-Mathijs Schoffelen

Results 283 comments of Jan-Mathijs Schoffelen

indeed, the data_clean.hdr.chantype has capitalized chantypes. What's the origin of this data?

I think I can add a change to ft_chantype: if isfield(input, 'chantype') % start with the provided channel types chantype = input.chantype(:); into chantype = lower(input.chantype(:)); That would make it...

Based on the above, the following would work as expected on the current data (with the current code) ft_chantype(rmfield(data_clean, 'hdr'), 'eeg')

I think that this one can be closed, @arnodelorme agrees? (I have silently pushed a change to the repo to ensure lower-cased chantypes )

Yes, it is still the case that the execution of the full set of test functions takes a long time. Some functionality to run parts of it (assuming there's no...

Yes, but those questions are very relevant ones, indeed!

Hi, can we change line 141 in ft_test into struct2table(struct(result)), rather than struct2table(result)? This would prevent a crash if result is empty.

sorry, to clarify: result can be empty, if the conditions on the test functions to be ran are too strict (e.g. dependency or maxwalltime or so)

I am not sure what is intended here, and what would be the idea to have a 'similar fashion' to ft_preproc_dftfilter. This function at hand is I think very rarely...

This is not going to be addressed anytime soon. Closing for now: feel free to reopen and suggest a PR with the intended functionality