Richard Schneeman comments

Results 473 comments of


                                            Richard Schneeman

Decouple layer ordering from layer name with an explicit interface

Updated after discussion from the working group meeting.

Decouple layer ordering from layer name with an explicit interface

I've responded to all comment threads and acted on all requests for changes. LMK if any other clarifications are needed.

Ensure and enforce that configs are loaded before options are accessed

Looks like capybara is still failing. I did a rough skim and made a few suggestions. I see a lot of changes to the tests to get them to pass,...

Ensure and enforce that configs are loaded before options are accessed

> and where that method (#assert_warning_for_hooks_defined_in_single_mode) is used. Great, thanks for enumerating that! I'm aiming to get v7 out before RailsWorld, if we're blocked here on an external PR, then...

Ensure and enforce that configs are loaded before options are accessed

Agreed with Greg, it's easier to review new, smaller commits once a chunk has already been reviewed. It's okay to rebase against master/main and force push still. In other news:...

replace fork_pipe with more robust implementation

I just swapped the default branch name from `master` to `main`, you don't need to do anything for this PR. You'll need to update your local environment accordingly: ``` $...

Struct with `tag` and `deny_unknown_fields` cannot deserialize

Thats an interesting idea. Can you link me to a playground link or post a raw rust example you're using? That snippet cannot compile as `serde::de::IgnoredAny` is not `Eq`: ```...

Deny std::fs functions

First off, I didn't know you could do this, and love the idea. I've been wondering how to write a custom linter rule for this exact same purpose, and disallowing...

Deny std::fs functions

I applied this to my repo and specified replacements for most. Commit is here: https://github.com/heroku/docker-heroku-ruby-builder/pull/92. ```toml disallowed-methods = [ # Use fs_errr functions, so the filename is available in the...

Wrap std::env::set_current_dir

Do we have a list of functions that produce a `std::io::Error` that operate on the filesystem that don't have an fs-err wrapper?