Tobias Munk comments

Results 508 comments of


                                            Tobias Munk

\yii\db\BaseActiveRecord::getDirtyAttributes causes Fatal Error in 2.0.46

also related https://github.com/yiisoft/yii2/issues/19531

Version 2.0.46 brakes saving in DB

> Hi @samdark, was there some discussion/progress on @bizley request to revert? @markch123 see https://github.com/yiisoft/yii2/issues/19546

Changed behavior of the `yii\base\BaseModel::attributes()` method in 2.0.46

The only place where `attributes()` itself is tested: https://github.com/yiisoft/yii2/blob/master/tests/framework/base/ModelTest.php#L524 We could reuse `Speaker` https://github.com/yiisoft/yii2/blob/161526cd41beee62d0910333c3bd96034cf73186/tests/data/base/Speaker.php for testing this, by checking for `firstName`, `lastName` on a newly created instance.

Changed behavior of the `yii\base\BaseModel::attributes()` method in 2.0.46

I wonder if `gii` works with 2.0.46, since the bug described here would render it completely unusable - untested, it's just a thought.

Changed behavior of the `yii\base\BaseModel::attributes()` method in 2.0.46

Should be reverted IMHO.

bower-asset/jsoneditor missing tags below 5.24.0

Seems to be working now, close at will. @eluhr triggered a rescan, btw.

Set the dropdown for anyOf or oneOf to a "choices" or typeable dropdown

Sounds like a cool addition, PRs welcome. It think it should use `choices`, `selectize` or `select2`, whichever is enabled and with an additional option to enable it.

maximum call stack exceed with 'max_depth=3'

Could you create a simpler example reproduction the problem?

maximum call stack exceed with 'max_depth=3'

Probably related: https://github.com/json-editor/json-editor/issues/1158

Allow object editors to use the "categories" layout, but with "grid" or "grid-strict" in the "Basic" tab

@bassmanitram Could you post a simple example with the "Basic" object and a schema how the schema/data should be.