twig.js icon indicating copy to clipboard operation
twig.js copied to clipboard

Twig2

Open DerManoMann opened this issue 8 years ago • 3 comments

Summary

  • require PHP7
  • follow Twig 2.x changes
  • update composer deps to new stable versions
  • update Makefile (plovr url)
  • add more PHP tests
  • rebuild twig.js and twig.dev.js

I've set the composer alias to 2.0.x-dev as this is a major update. Not sure if this should go onto a 2.0 branch first and leave master for twig 1.x compatibility for now. Not sure how much more work is going into Twif 1.x...

DerManoMann avatar Feb 07 '17 08:02 DerManoMann

Failing tests are related to the changed prefix for macros in Twig, ie:

https://github.com/twigphp/Twig/blob/2.x/lib/Twig/TokenParser/From.php#L48 https://github.com/twigphp/Twig/blob/2.x/lib/Twig/ExpressionParser.php#L405

DerManoMann avatar Feb 07 '17 23:02 DerManoMann

Someone plan to merge this PR into master ?

alexis-gruet-deel avatar Jun 17 '17 21:06 alexis-gruet-deel

Hey @henrycatalinismith, is there anything we can do to push this along?

TomA-R avatar May 04 '23 14:05 TomA-R