UnserializeObjectConstructor should be renamed to reflect what it actually does

[Majkl578]

Q	A
Feature request?	yes
BC Break	yes

UnserializeObjectConstructor currently only delegates construction to Doctrine Instantiator, therefore the unserialize part is not valid.

[goetas]

actually happens the opposite.

First the DoctrineObjectConstructor is invoked, if the object is not managed by doctine then the UnserializeObjectConstructor is invoked.

[Majkl578]

Huh, are we talking about the same thing? https://github.com/schmittjoh/serializer/blob/5a31421e56e1f4ea52c28816d243708743b266d0/src/Construction/UnserializeObjectConstructor.php#L17-L32

This does no unserialization on its own.

[goetas]

..... yeah, before the use of Doctrine\Instantiator\Instantiator was using the php unserialize trick to create an object without calling the constructor...

https://github.com/schmittjoh/serializer/blob/f1137df4d3a812c9c1aa7f9b6674b31b983f913e/src/JMS/Serializer/Construction/UnserializeObjectConstructor.php

[goetas]

Ahhh, i see your point now... I misread the initial comment. sorry.