JMSTranslationBundle
JMSTranslationBundle copied to clipboard
schmittjoh
Feature/extract concat strings
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #296 |
| License | Apache2 |
Description
Just added a small change so in case you have a long concatenated strings in your code, you can use the bundle to extract those strings into your translation files. It basically converts the concatenated strings into one string before passing it to extraction.
Todos
- [x] Tests
- [x] Documentation
- [ ] Changelog
This is replacing https://github.com/schmittjoh/JMSTranslationBundle/pull/336
I'm not sure about the part "It only adds the ability to handle concatenated strings to regular php files. Is it not possible to support this with other files like the form extractor?"
I haven't used that feature but I can add the fix there too, I would need some details though on where to add the fix, is it only affecting FormExtractor class? Or it should be added in other places too?
