JMSSerializerBundle
JMSSerializerBundle copied to clipboard
schmittjoh
Please upgrade minimum version of jms/serializer in 2.x composer.json
I encountered a bug regarding metadata serialization when travis-ci was installing dependencies through composer update --prefer-lowest that i was able to solve with requesting a minimum version of ^1.13 for jms/serializer.
see https://github.com/schmittjoh/serializer/releases/tag/1.13.0
I think you should increase the minimum version of jms/serializer in your project as most probably it affects your application. For other projects, a version lower than 1.13 could work.
ok, this is your decision :) "my" project is the NelmioApiDocBundle where i had to add the jms/serializer to the dependencies in composer.json just to overwrite the one required by this project, to make all the tests pass again after removing the empty catch that prevented this bug to appear. So i thought i could help other people not to spend time on bugs that are solved already, but again it's your choice.
P.S. wow, it was you who released 1.13 and should know of the severity of this bugfix -- zero thanks for wasting my time.
I encountered a bug regarding metadata serialization when travis-ci was installing dependencies through composer update --prefer-lowest that i was able to solve with requesting a minimum version of ^1.13 for jms/serializer.
If you can send a failing test case, will be happy to fix.
Your ticket does not describe at all which kind of issue you had except of a phrase: "I encountered a bug regarding metadata serialization"
there is nothing to be fixed besides requiring the minimum fixed version of jms/serializer 1.13 which according to semantic release versions in composer.json should be compatible with the current minimum required version. And maybe you could at least try to understand the severity of never successful executing code for a project that you seem to maintain. As for the question about a test, go look for it by yourself in https://github.com/schmittjoh/serializer/pull/969
I think you misunderstood semantic versioning. Version bumps do not happen on upstream project when there is a new release of down-stream projects...
to make an example, following this logic projects as doctrine/orm now will be version 2.486926 considering all the bugfix releases in projects that doctrine depends on (as dbal, yaml, common and so on...)
In the case of such a bugfix as in version 1.13, i'd say a new release of upstream is badly needed.
https://github.com/semver/semver/issues/148 tries to understand which one is the right thing to do
(is a bit not php-focused but it gives the idea...)
And then i guess (because i no longer will spend time on this) at least one *of this issues is related to that (but don't nail me on it) https://github.com/schmittjoh/JMSSerializerBundle/search?q=propertymetadata&state=open&type=Issues *edit