JMSSecurityExtraBundle icon indicating copy to clipboard operation
JMSSecurityExtraBundle copied to clipboard

Dont call addClassesToCompile on PHP 7.0, its deprecated

Open bobvandevijver opened this issue 8 years ago • 4 comments

As addClassesToCompile is deprecated in Symfony, it should also be removed here.

See https://github.com/symfony/symfony/issues/20668 for the discussion about deprecation. See https://github.com/doctrine/DoctrineBundle/pull/608 for a similar PR on DoctrineBundle.

Fixes #218.

bobvandevijver avatar Oct 27 '17 16:10 bobvandevijver

can this be merged ? It prevents many projects to upgrade to SF4 if we have dependency on JMSSecurityExtraBundle.

odoucet avatar Dec 06 '17 13:12 odoucet

Any status / infos about this? @schmittjoh?

COil avatar Mar 05 '18 16:03 COil

@schmittjoh could you merge it?

pzienowicz avatar Jun 15 '18 11:06 pzienowicz

This package seems abandoned. I have switched to Symfony security annotations (if you are using Symfony)

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;

 * @Security("has_role('ROLE_USER')")

COil avatar Jun 15 '18 11:06 COil