JMSI18nRoutingBundle icon indicating copy to clipboard operation
JMSI18nRoutingBundle copied to clipboard

[Fix] Changed localeChoosingListener on kernel request

Open Losams opened this issue 6 years ago • 5 comments

Type : [Fix] Problem with the welcome page on symfony 3.4.7

On symfony 3.4.7, the welcome page didn't throw an exception anymore (in debug mode). The localeChoosingListener has been put in kernel.request instead.

Losams avatar Apr 06 '18 11:04 Losams

Thank you @Losams for you work, I hope this can be merged soon.

grizzlylab avatar Apr 24 '18 13:04 grizzlylab

Thanks @Losams will try to take a look at the issue this weekend.

acasademont avatar Apr 24 '18 14:04 acasademont

@acasademont Any updates? :)

XWB avatar May 30 '18 10:05 XWB

hey guys, so sorry for the late review. I'm trying to understand what's the underlying problem here, one test is also failing due to the patch. Could you please elaborate a bit more @Losams?

acasademont avatar Jun 27 '18 12:06 acasademont

Yes IDK why the "testNoCookieOnError" crashed, to be honest I didn't check so far. All I can say is what I said on the commit : "On symfony 3.4.7, the welcome page didn't throw an exception anymore (in debug mode)." So the localeChoosingListener didn't fire anymore (only on debug env). For that I changed the dispatch to kernel.request

Losams avatar Jun 27 '18 13:06 Losams