JMSI18nRoutingBundle icon indicating copy to clipboard operation
JMSI18nRoutingBundle copied to clipboard

Bug/resolve locale

Open qpautrat opened this issue 9 years ago • 8 comments

Resolve locale from current host See #128

qpautrat avatar Jun 30 '15 09:06 qpautrat

+1

Can this PR be merged please ?

pitpit avatar Oct 13 '15 10:10 pitpit

Hi @qpautrat thanks for the patch, could you please rebase with the new master?

acasademont avatar Dec 02 '15 09:12 acasademont

@acasademont Done !

qpautrat avatar Dec 02 '15 09:12 qpautrat

@qpautrat thanks but i'm afraid there must be something wrong here, in your PR there are also some of my commits and the diff is not clear. Can you please squash and make sure there's only 1 commit and the diff is clear? Thank! :D

acasademont avatar Dec 02 '15 10:12 acasademont

@acasademont Is this ok now ? I'm really sorry, i'm not used to do that, kind of beginner here. :confused:

qpautrat avatar Dec 02 '15 10:12 qpautrat

Thanks! Could you fix the small thing I mentioned and squash all the commits please?

acasademont avatar Dec 02 '15 16:12 acasademont

@acasademont Done.

qpautrat avatar Dec 03 '15 09:12 qpautrat

what about this PR ? Could it be merged please ?

pitpit avatar Sep 14 '18 12:09 pitpit