JMSDiExtraBundle icon indicating copy to clipboard operation
JMSDiExtraBundle copied to clipboard

implemented missing methods, fixes issue #28

Open youbs opened this issue 12 years ago • 8 comments

These are @jonathaningram changes (plus the finder as suggested by @schmittjoh)

youbs avatar Jun 21 '12 12:06 youbs

@schmittjoh Can you have a look as soon as possible as I'm waiting for this fix to release 2.1.0 beta1. Thanks.

fabpot avatar Jun 21 '12 13:06 fabpot

I can't verify this patch until I'm home, but apparently it does not work judging from the comments on #28.

schmittjoh avatar Jun 21 '12 14:06 schmittjoh

I've reverted the code from Symfony master for now as it introduces too many regression. Of course, this PR is still important as the code will be reintroduced for Symfony 2.1 beta1.

fabpot avatar Jun 21 '12 17:06 fabpot

@fabpot, do you think the interface will change until then?

schmittjoh avatar Jun 22 '12 00:06 schmittjoh

until beta1 ? no as it is released :) I will be for beta2 in fact

stof avatar Jun 22 '12 07:06 stof

Hello so now when I update my project via composer I get the error :

Warning: Class JMS\DiExtraBundle\Config\FastDirectoriesResource has no unserializer

Do you miss something to merge this PR ?

nicolas-bastien avatar Jun 26 '12 10:06 nicolas-bastien

@nicolas-bastien just double check you rm -rf app/cache/dev - i.e. manually remove the cache just in case.

jonathaningram avatar Jun 26 '12 10:06 jonathaningram

@jonathaningram thanks I did it but as I have copied youbs change before I thought the correction came from this and not my cache ! So it's ok I don't have the problem anymore, thanks.

nicolas-bastien avatar Jun 26 '12 11:06 nicolas-bastien