schmidt9

Results 17 comments of schmidt9

@rzakhar please check first test that uses images input (https://github.com/devexperts/suitcase/pull/10/commits/cd7d960706d3ab01dfeed12851b67cbc49058317), it works, but fails on pixels comparison inside `assertComparison` method (`actualDifference.image == expectedDifference.image`). Meanwhile Difference values pass test with given...

@rzakhar I mean pixels arrays are being compared always strict so test will always fail with any non-zero difference

`XCTAssertTrue(actualDifference.image == expectedDifference.image, file: file, line: line)` does not takes into account any accuracy

Sorry I don't get you idea. In my understanding if I reuse images produced by SUITCase itself the strict test should pass out of the box. I don't get why...

While testing difference images I noticed a strange thing - Difference image from assets turns green when converted to `RGBAImage` ``` let differenceImage = UIImage(named: "en_iPhone_X_difference_strict", in: .module, compatibleWith: nil)!...

> What is the difference between difference images? Would you please provide examples? Running in `assertComparison` with strict method: ``` let actualDifference = try method.compareImages(actual: image1.uiImage, reference: image2.uiImage) let differenceDifference...

> Hey! Thanks for the PR. Remember to include a proper explanation to the PR. Things that can help: > > 1. Clear title that shortly explains the changes >...