marinara icon indicating copy to clipboard operation
marinara copied to clipboard

Translation to other languages

Open schmich opened this issue 6 years ago • 41 comments

Welcome

Marinara is a free Pomodoro time management assistant extension for Google Chrome with over 300,000 weekly users.

The GitHub community has helped translate this extension into over 30 languages, but some languages are still missing (see below).

How to Contribute

  1. Check the open pull requests to make sure there's not already an outstanding PR for the language you're targeting (it can take a few days for me to incorporate PRs).

  2. Use the Marinara Localization tool and follow the Translation Guide.

  3. Add yourself to CONTRIBUTORS.md.

Missing Languages

Marinara is missing translations for the following languages:

ID Language
am Amharic
bg Bulgarian
et Estonian
fil Filipino
gu Gujarati
hi Hindi
hr Croatian
hu Hungarian
kn Kannada
lv Latvian
ml Malayalam
sl Slovenian
ta Tamil

schmich avatar Oct 08 '17 20:10 schmich

I'm a native Spanish speaker (Chilean) and I'll be happyto help you out with the translation.

ofou avatar Oct 15 '17 19:10 ofou

@schmich I already told you, you can count on me for portuguese translations ;) What do you think about to put the label Hacktoberfest on this? We could translate to much more languages

joselcvarela avatar Oct 15 '17 22:10 joselcvarela

HI @schmich, I already started working on this, but I have a question. Do we need to translate message and description or just message keys? Also, I just noticed this translations doesn't include the settings page.

joselcvarela avatar Oct 17 '17 19:10 joselcvarela

You only need to translate the message values. The description is just to give you some context to assist with translation.

Also, some messages are parameterized with $parameter$. In this case, too, only message needs to be localized (the $parameter$ does not need to be localized since it will be replaced).

  "pomodoro_count_many": {
    "message": "$count$ Pomodoros",
    "description": "Label for many Pomodoros. Shown on the expiration page.",
    "placeholders": {
      "count": {
        "content": "$1",
        "example": "10"
      }
    }
  }

I'm still working through internationalizing everything (some parts of the UI are tricky), but I'm hoping to have it done by today. Adding the Hacktoberfest tag is a great idea. I'll add it once everything is ready.

schmich avatar Oct 17 '17 20:10 schmich

I finished the Spanish translation, it is my first contribution, so I don't know if I've done it correctly. Any advice will be appreciated.

ofou avatar Oct 17 '17 23:10 ofou

Hey, I'd wanted to say something about the Chrome locale table, because I'm doing the es_419 #83 (Latin America and Caribbean) translation but it's kind of the same for es (Spain). I lived in Spain for five years and they use the same expresions. I really don't know how Chrome locale table works for Spaniards, do they get the same as es_419?

ofou avatar Oct 18 '17 02:10 ofou

I really don't know how Chrome locale table works for Spaniards, do they get the same as es_419?

Right now, they wouldn't. en is the default, es is more specific, and es_419 is even more specific. Chrome resolves locales from most-to-least specific, so if someone ran Chrome as es-ES (Spanish/Spain), Chrome would look for the es locale, see that it was missing, and then fall back to the en locale.

I'm not familiar with the differences between Spanish and Spanish (Latin America and Caribbean), but from what you're saying, it sounds a lot like the difference between US English (en-US) and British English (en-GB): some things are spelled differently, some things are named slightly differently, but mostly they're the same language and either can be understood by a native English speaker.

If that's the case, I think we should just rename es_419 to es to cover all of Spanish. If you want to update it and send a pull request, that would be great.

schmich avatar Oct 18 '17 04:10 schmich

@joselcvarela @Peel40 Internationalization is complete (minus any small strings I might've missed), so the extension is ready for full translation. You should update/recreate your forks with the latest source before translating.

As features are added, I might add more English strings. To keep the localizations in sync, I created a Ruby script to sync the en locale to any other locale. The new messages are marked with FIXME in the destination locale. (If you have Ruby installed, you can run make sync-locale from the source root to do the sync yourself).

@Peel40 I went ahead and updated es_419/messages.json with that sync script. The new messages are marked FIXME.

schmich avatar Oct 18 '17 11:10 schmich

This extension rocks! I would love to add German localization.

alexkolson avatar Oct 18 '17 18:10 alexkolson

@alexkolson Fantastisch! I took a few years of German in school and I have some German family roots, but I'd fail miserably if I tried.

I added you to the list up top. The Translation Guide should be all you need, but let me know if anything is unclear.

schmich avatar Oct 18 '17 18:10 schmich

Working on Greek translation!

LambisElef avatar Oct 19 '17 18:10 LambisElef

I can translate to Norwegian

wkillerud avatar Oct 20 '17 04:10 wkillerud

I can translate to pt-BR

samcarecho avatar Oct 20 '17 16:10 samcarecho

Bengali translation done!

MAHRahat avatar Oct 20 '17 21:10 MAHRahat

Fixed some Dutch spelling mistakes ;) https://github.com/schmich/marinara/pull/109

haveneersrobin avatar Oct 23 '17 18:10 haveneersrobin

I'll work on Ukrainian

Kietzmann avatar Oct 25 '17 13:10 Kietzmann

zh_TW translation done!

Sirius207 avatar Oct 25 '17 13:10 Sirius207

Happy Hacktoberfest! #121

sgbasaraner avatar Oct 27 '17 04:10 sgbasaraner

Release 10 was just published to the Chrome Web Store with all of the translations. Thanks again, everyone, for helping with this effort.

I created the Chrome Extension Localization project for managing translations going forward. If you know of other Chrome extensions that could benefit from managing their translations, please pass it along.

The Marinara Localization tool will show you what translations are missing or outdated, and you can use it to update translations. For more details, see the Translation Guide.

schmich avatar Nov 07 '17 22:11 schmich

Hi @schmich ,

I can help with the Catalan translation, I will start working on it soon :)

Also, I've seen that there are some strings missing translation for Spanish (es-ES), I can help with that translation as well as reviewing it.

mcmtradu avatar Feb 20 '18 10:02 mcmtradu

@mcmtradu Welcome! That would be fantastic. The steps I mention at the top are accurate and up-to-date, so you should be able to follow them without a problem.

If you hit any issues, feel free to ask a question here or email me directly.

schmich avatar Feb 20 '18 16:02 schmich

Hi @schmich, this is a super useful extension. I found that Japanese (ja) translation is missing. Would love to add it.

abrarShariar avatar Aug 15 '18 08:08 abrarShariar

No Italian? I will work on it

giovannipessiva avatar Sep 30 '18 22:09 giovannipessiva

I will work on Indonesian

ridho9 avatar Oct 01 '18 14:10 ridho9

Hey, I submitted the Persian translation but I cannot see it. Why?

pooriamo avatar Jun 09 '19 12:06 pooriamo

@pooriamo It looks like you've created your own fork with your changes successfully. Now, all you need to do is submit a pull request.

Once you do so, I will be able to accept and integrate your changes into the main repository here. Thanks for your contribution! Let me know if you need more assistance.

schmich avatar Jun 09 '19 13:06 schmich

@schmich I already did it as your instructions, I tried again and now it says: schmich:master and pooriamo:master are identical.

pooriamo avatar Jun 09 '19 14:06 pooriamo

@pooriamo Your changes are in your own fork, and also in a branch off of the master branch. In this case, your changes are in your patch-1 branch.

When creating the pull request, you'll want to compare schmich:master with pooriamo:patch-1.

Branch selection should be near the top when creating a PR. See step 4 in creating a pull request.

schmich avatar Jun 09 '19 14:06 schmich

@schmich Oh I'm sorry dear. Done!

pooriamo avatar Jun 09 '19 14:06 pooriamo

Hello @schmich, just added the Malay language to Marinara! Submitted 2 PRs (one in messages.JSON & one in the Contributors.md). Hope you will approve it as one of Marinara's extensions :')

rachelnml avatar Aug 02 '20 12:08 rachelnml